ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

enable the AnsibleTurboModule #392

Closed goneri closed 3 years ago

goneri commented 3 years ago

Use AnsibleTurboModule when the cloud.common collection is available.

codecov[bot] commented 3 years ago

Codecov Report

Merging #392 (b1bb3b7) into main (39660dd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files           1        1           
  Lines         151      151           
  Branches       24       24           
=======================================
  Hits           35       35           
  Misses        111      111           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39660dd...b1bb3b7. Read the comment docs.

gravesm commented 3 years ago

The CI is now failing for three reasons:

  1. 2.7 incompatibility. Maybe we can just drop 2.7 from the test matrix since it sounds like we may not be supporting it?
  2. A legitimate linting error in cloud.common. If there's a way to ignore errors in cloud.common I'd be fine with that as it's not really this collection's problem. It should probably be fixed in cloud.common, though.
  3. The known issue with molecule 3.3.0. I'll pin our molecule dependency in a separate PR and we can rebase to fix this problem.
gravesm commented 3 years ago

Unless I'm missing something ansiblemodule.py and ansiblemodule_turbo.py are exactly the same. Is there a reason we need both?

goneri commented 3 years ago

See: https://github.com/ansible-collections/kubernetes.core/pull/68

github-actions[bot] commented 3 years ago

This repository does not accept pull requests, see the README for details.