Sanity tests failing in community.libvirt

[dmsimard]

SUMMARY

We are running sanity tests across every collection included in the Ansible community package (as part of this issue) and found that ansible-test sanity --docker against community.libvirt 1.0.2 fails with ansible-core 2.13.0rc1 in ansible 6.0.0a2.

ISSUE TYPE

• Bug Report

COMPONENT NAME

n/a

ANSIBLE VERSION

ansible [core 2.13.0rc1]

COLLECTION VERSION

1.0.2

STEPS TO REPRODUCE

ansible-test sanity --docker

EXPECTED RESULTS

Tests are either passing or ignored.

ACTUAL RESULTS

ERROR: Found 1 import issue(s) on python 3.10 which need to be resolved:
ERROR: plugins/connection/libvirt_lxc.py:27:0: traceback: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
ERROR: Found 3 replace-urlopen issue(s) which need to be resolved:
ERROR: tests/utils/shippable/check_matrix.py:22:25: use `ansible.module_utils.urls.open_url` instead of `urlopen`
ERROR: tests/utils/shippable/check_matrix.py:25:32: use `ansible.module_utils.urls.open_url` instead of `urlopen`
ERROR: tests/utils/shippable/check_matrix.py:52:31: use `ansible.module_utils.urls.open_url` instead of `urlopen`
ERROR: Found 1 shebang issue(s) which need to be resolved:
ERROR: tests/utils/shippable/timing.py:1:1: unexpected non-module shebang: b'#!/usr/bin/env python3.7'
ERROR: Found 1 shellcheck issue(s) which need to be resolved:
ERROR: tests/utils/shippable/shippable.sh:53:10: SC2242: Can only exit with status 0-255. Other data should be written to stdout/stderr.
ERROR: Found 9 validate-modules issue(s) which need to be resolved:
ERROR: plugins/connection/libvirt_lxc.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Michael Scherer <misc@zarb.org>'
ERROR: plugins/connection/libvirt_lxc.py:0:0: invalid-documentation: DOCUMENTATION.connection: extra keys not allowed @ data['connection']. Got 'community.libvirt.libvirt_lxc'
ERROR: plugins/connection/libvirt_lxc.py:0:0: invalid-documentation: DOCUMENTATION.name: required key not provided @ data['name']. Got None
ERROR: plugins/connection/libvirt_qemu.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Jesse Pretorius <jesse@odyssey4.me>'
ERROR: plugins/connection/libvirt_qemu.py:0:0: invalid-documentation: DOCUMENTATION.connection: extra keys not allowed @ data['connection']. Got 'community.libvirt.libvirt_qemu'
ERROR: plugins/connection/libvirt_qemu.py:0:0: invalid-documentation: DOCUMENTATION.name: required key not provided @ data['name']. Got None
ERROR: plugins/inventory/libvirt.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['Dave Olsthoorn <dave@bewaar.me>']
ERROR: plugins/inventory/libvirt.py:0:0: invalid-documentation: DOCUMENTATION.plugin_type: extra keys not allowed @ data['plugin_type']. Got 'inventory'
ERROR: plugins/inventory/libvirt.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: The 5 sanity test(s) listed below (out of 43) failed. See error output above for details.
import --python 3.10
replace-urlopen
shebang
shellcheck
validate-modules
ERROR: Command "podman exec ansible-test-controller-Qz53pFxm /usr/bin/env ANSIBLE_TEST_CONTENT_ROOT=/root/ansible_collections/community/libvirt LC_ALL=en_US.UTF-8 /usr/bin/python3.10 /root/ansible/bin/ansible-test sanity --containers '{}' --skip-test pylint --metadata tests/output/.tmp/metadata-8l5hgc_o.json --truncate 0 --color no --host-path tests/output/.tmp/host-arl29y7l" returned exit status 1.

[Andersson007]

cc @csmart (if you have no time, let me know) plus after the tests are fixed, we need to release the collection

[csmart]

@Andersson007 I should be able to look into this later today