ansible-collections / community.libvirt

Manage libvirt with Ansible
http://galaxy.ansible.com/community/libvirt
GNU General Public License v3.0
61 stars 41 forks source link

Add lxml Python dependency to documentation. #166

Closed zhengyi13 closed 9 months ago

zhengyi13 commented 1 year ago

fixes #165

SUMMARY

lxml seems a requirement, and isn't explicitly stated, and isn't necessarily available by default.

ISSUE TYPE
COMPONENT NAME

virt

ADDITIONAL INFORMATION

See the linked issue.

zhengyi13 commented 1 year ago

So, four "remote devel" tests are failing, all the same way:

00:19 FATAL: A Python version was not specified for environment `--docker opensuse15`. Use the `--python` option to specify a Python version.

I'm totally unfamiliar with the testing setup on this project. If this is triggered by the modification of plubings/doc_fragments/requirements.py, should I drop that file from this PR? Or does someone more knowledgeable than me need to fix the tests?

csmart commented 9 months ago

@zhengyi13 thanks for the MR! I think the tests are failing for some other reasons too and have a branch to try and get those going. I'll merge in your docs change now, rather than waiting for the tests to be fixed, thanks very much!