ansible-collections / community.libvirt

Manage libvirt with Ansible
http://galaxy.ansible.com/community/libvirt
GNU General Public License v3.0
61 stars 42 forks source link

Refactor all plugins for better maintenance #38

Open odyssey4me opened 4 years ago

odyssey4me commented 4 years ago
SUMMARY

Each of the modules are independent bits of code, but we could refactor them all to use common objects, methods, etc which would make their implementations more consistent and easier to maintain.

There are also some great ideas and samples in https://github.com/ansible/ansible/issues/27905 which are worth looking at.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
simsiem commented 4 years ago

Hi odyssey4me,

because of the issue #47, I stumbled across this issue.

I wonder what is the status or plan here? Should we fix #47 or do we have some joint capacity to rewrite the network plugin?

odyssey4me commented 4 years ago

I would sincerely love some help to work on refactoring. I'm hoping to make some time to get to it, but I'm sensitive to the fact that any refactoring should involve ensuring decent test coverage first. If you're able to help with that, then it'd go a long way to improving the quality and maintainability of the modules.