search

ansible-collections / community.mysql

MySQL Ansible Collection
https://galaxy.ansible.com/ui/repo/published/community/mysql/
Other
98 stars 87 forks source link

[5.0.0] drop mysqlclient #654

Open markuman opened 2 months ago

markuman commented 2 months ago

...after it was marked as deprecated in 4.0.0 https://github.com/ansible-collections/community.mysql/issues/646

Andersson007 commented 2 months ago

@markuman @laurent-indermuehle @betanummeric how about marking it deprecated now with a warning now and stopping testing against in 4.0.0 (doesn't necessarily mean it'll stop working)? we are not planning to release 4.0.0 this year anyway. I think we could release 4.0.0 in late May 2025, so emo enough time for folks to switch (again, stopping testing doesn't mean it'll working). Ideas?

Andersson007 commented 2 months ago

please take a look at the PR https://github.com/ansible-collections/community.mysql/pull/655/files

betanummeric commented 2 months ago

@Andersson007 @markuman @laurent-indermuehle Adding a deprecation warning now sounds good. Why would you delay the next major release until May 2025? Just to give the deprecation warning some time?

Unless there are other reasons, I would approve releasing 4.0.0 earlier and directly remove all mysqlclient-sepcific code in that release. The current major release 3.x.x, including mysqlclient testing, will be supported for two years after the next major release. So users get two years time to switch to pymysql, during which they get mysqlclient-tested minor and patch releases. I would not keep the mysqlclient-specific code and stop to test that. This may work, may break, or worse: appear to work with some subtle dangerous bug. Of course we can add warnings, but errors are more visible. What do you think?

Andersson007 commented 2 months ago

@betanummeric to release 4.0.0 earlier SGTM, though it also depends on volunteers to do it:) how about releasing it after next Ansible major release, iirc it should happen in November Thoughts? Also folks please take a quick look at https://github.com/ansible-collections/community.mysql/pull/655 and approve if it's OK

Andersson007 commented 2 months ago

Merged, thanks everyone! Created a milestone for 5.0.0, added a task to 4.0.0. FYI