petermcd
commented
4 years ago I originally posted the above issue on the official Ansible GitHub but was directed here instead
I am currently undecided as to whether this is now a bug or not and will leave it here for discussion.
The argument appears to be between the following options
- Mark the task as skipped and have to work out if it was skipped for a genuine reason or if the device failed to add (by either polling the FortiManager to ascertain if the device exists or by updating the playlist like below). The disadvantages if this is that the overall Playbook will fail on the first device failure.
- Mark the task as failed and have the playbook continue on failures. This potentially causes a playbook with multiple tasks to add a device to continually attempt to create those devices when for example you cant connect to the FortiManager.
- name: Add Fortinet Device
hosts: FortiManager
connection: httpapi
tasks:
- name: Discover and add device
register: command_output
vars:
ansible_command_timeout: 60
fmgr_device:
adom: "root"
device_username: "dfghjfgjmfgh"
device_password: "sfjrgkr"
device_ip: "192.168.1.1"
device_unique_name: "xhgmgkhyj"
mode: "add"
blind_add: "disable"
- name: fail
fail:
msg: "{{ command_output['ansible_module_results']['status']['message'] }}"
when: "-20042 == command_output['ansible_module_results']['status']['code']"
ansibullbot
sanjay-chahar
SUMMARY
When utilising the fmgr_device module to add a new device the module reports skipped when the API call failed due to the device not being available.
ISSUE TYPE
COMPONENT NAME
fmgr_device
ANSIBLE VERSION
The below version was also modified to include the correct fortimanager.py file to resolve the httpapi bug.
ansible 2.9.7 config file = None configured module search path = ['/home/peter/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /home/peter/.virtualenvs/ansibletest/lib/python3.6/site-packages/ansible executable location = /home/peter/.virtualenvs/ansibletest/bin/ansible python version = 3.6.9 (default, Nov 7 2019, 10:44:02) [GCC 8.3.0]
CONFIGURATION
No output (no custom configuration)
OS / ENVIRONMENT
Linux petermcd.dev 4.15.0-96-generic #97-Ubuntu SMP Wed Apr 1 03:25:46 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
STEPS TO REPRODUCE
1) Create the below playbook and call it device_create.playbook (this has details of a device that does not exist to purposely cause a failure):
2) create a host group called FortiManager with valid credentials associated
3) perform the following call:
ansible-playbook device_create.playbook
EXPECTED RESULTS
PLAY [Add Fortinet Device] *****
TASK [Gathering Facts] ***** ok: [device-name]
ACTUAL RESULTS
The task is marked as skipped with no error being output for the call. As can be seen from the error in the -vvvv call below the device could not be added to the FortiManager as the probe failed.