search

ansible-collections / community.network

Ansible Community Network Collection
http://galaxy.ansible.com/community/network
Other
124 stars 90 forks source link

Add A Requirements File To Bring In Dependencies Automatically #564

Closed timway closed 11 months ago

timway commented 11 months ago
SUMMARY

Resolves #146 by making it more obvious this collection has a python dependency with newer versions of Ansible.

ISSUE TYPE
COMPONENT NAME

community.network.aireos

ADDITIONAL INFORMATION

With the diverse set of modules present in this collection we may encounter situations in the future where we have to either break-out or fix modules to use consistent dependencies.

timway commented 11 months ago

This is included in ansible.netcommon for some SCP use cases (per git-blame) so my EE built and happened to have it anyways because of the collection level dependency on ansible.netcommon. I'm a proponent of leaving this file in this repo as it makes the unique dependency in aireos obvious and doesn't create an unrelated dependency on ansible.netcommon.

Andersson007 commented 11 months ago

closed-reopened to restart the tests after i fixed them

patchback[bot] commented 11 months ago

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/d1517e0a4c458f40d3be6d31f2da5ca4d37f319b/pr-564

Backported as https://github.com/ansible-collections/community.network/pull/570

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] commented 11 months ago

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/d1517e0a4c458f40d3be6d31f2da5ca4d37f319b/pr-564

Backported as https://github.com/ansible-collections/community.network/pull/569

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

Andersson007 commented 11 months ago

@timway hi, thanks for the contribution!

thanks