Open dahast opened 4 months ago
@dahast hello, thanks for reporting the issue Pinging folks specified as maintainers in BOTMETA.yml @xen0l @danowar2k @fishman @jasperla @jpdasma @mator @scathatheworm @troy2914
I'm sorry, but why am I listed as a maintainer here? I have never to my knowledge contributed to this repository...
@danowar2k i don't know, this stuff was moved here from ansible/ansible. Anyway, removed you from the file https://github.com/ansible-collections/community.network/pull/599. If you recall you should be there, please let me know, i'll revert the PR, thanks
Thanks for removing me! (A long while back I was a little bit active in some Solaris Ansible modules, maybe this was residue from then)
SUMMARY
community.network.flowadm without maxbw fails on second run
ISSUE TYPE
COMPONENT NAME
community.network.flowadm
ANSIBLE VERSION
COLLECTION VERSION
CONFIGURATION
OS / ENVIRONMENT
illumos
STEPS TO REPRODUCE
It's legal to create a flow without properties priority or maxbw. In my case it was just to maintain order of udp packages to a certain port.
For the task both properties are optional, priority is set to 'medium' in this case, maxbw is unset.
On first run the task creates the flow without the properties, that's ok.
But on second run the task first determines if flow needs update, which is set to true, because the flowadm show-flowprop returns '?' for maxbw, which is not equal to the required maxbw (''). Then the task tries to run an flowadm set-prop, but add not props. The resulting cmd fails.
The task should handle the '?' properly and moreover the update should do a flowadm reset-prop if maxbw changes from a value to none in the task.
Run this twice:
EXPECTED RESULTS
ok on second run
ACTUAL RESULTS
fail on second run