search

ansible-collections / community.network

Ansible Community Network Collection
http://galaxy.ansible.com/community/network
Other
124 stars 89 forks source link

IronWare disable_pager function incorrect command #73

Open Akasurde opened 4 years ago

Akasurde commented 4 years ago

From @dbrummer on Apr 22, 2019 22:20

SUMMARY

The IronWare Terminal Plugin (/ansible/plugins/terminal/ironware.py) uses the old/incorrect command to disable paging in the "disable_pager" function. The correct command is 'skip-page-display' instead of 'terminal length 0'.

ISSUE TYPE
COMPONENT NAME

IronWare Terminal Plugin - /ansible/plugins/terminal/ironware.py

ANSIBLE VERSION
ansible 2.7.6
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/dbrummer/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]
CONFIGURATION

N/A - blank output from ansible-config dump --only-changed

OS / ENVIRONMENT

Ansible Host :

Linux dbrummer-svr 4.15.0-47-generic #50-Ubuntu SMP Wed Mar 13 10:44:52 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Distributor ID: Ubuntu Description: Ubuntu 18.04.2 LTS Release: 18.04 Codename: bionic

Networking host:

sh ver

Copyright (c) 1996-2016 Brocade Communications Systems, Inc. All rights reserved. UNIT 1: compiled on May 30 2018 at 08:15:13 labeled as FCXR08030s (10539581 bytes) from Primary FCXR08030s.bin SW: Version 08.0.30sT7f3 Boot-Monitor Image size = 370695, Version:10.1.00T7f5 (grz10100) HW: Stackable FCX648S

STEPS TO REPRODUCE

Run any commands on an IronWare device using 'ironware_command'.

      - name: get start-config brocade_net
        ironware_command:
          commands: show configuration
        register: output
EXPECTED RESULTS

Configuration of the device

ACTUAL RESULTS
The full traceback is:
Traceback (most recent call last):
  File "/usr/local/bin/ansible-connection", line 106, in start
    self.connection._connect()
  File "/usr/local/lib/python2.7/dist-packages/ansible/plugins/connection/network_cli.py", line 334, in _connect
    self._terminal.on_open_shell()
  File "/usr/local/lib/python2.7/dist-packages/ansible/plugins/terminal/ironware.py", line 42, in on_open_shell
    self.disable_pager()
  File "/usr/local/lib/python2.7/dist-packages/ansible/plugins/terminal/ironware.py", line 49, in disable_pager
    raise AnsibleConnectionFailure('unable to disable terminal pager')
AnsibleConnectionFailure: unable to disable terminal pager

fatal: [vdc-3960-mrp-gw1]: FAILED! => {
    "msg": "unable to disable terminal pager"
}

Copied from original issue: ansible/ansible#55630

Akasurde commented 4 years ago

From @mjgehrmann on Aug 06, 2019 00:18

@dbrummer I have a PR in. No idea how to get movement on this one.

Akasurde commented 4 years ago

From @nahun on Aug 28, 2019 00:55

FYI as a workaround you can copy the edited ironware.py terminal plugin to a "terminal_plugins" folder and run Ansible that way. I doubt the file will change much until the PR gets completed so its pretty safe.

ansibullbot commented 3 years ago

cc @paulquack click here for bot help