search

ansible-collections / community.proxysql

ProxySQL Ansible Collection
http://galaxy.ansible.com/community/proxysql
GNU General Public License v3.0
21 stars 26 forks source link

Added missing gtid_port to proxysql_backend_servers module #118

Open thanos-k opened 2 years ago

thanos-k commented 2 years ago
SUMMARY

Added missing gtid_port to proxysql_backend_servers module

Fixes #117

ISSUE TYPE
COMPONENT NAME

modules/proxysql_backend_servers

markuman commented 2 years ago

@thanos-k Thanks for the quick PR.
We need also an integration test, that verified that the parameter is working correctly. Mainly test to change the gtid_port of an existing row/record.

You can try to expand the existing test: https://github.com/ansible-collections/community.proxysql/tree/main/tests/integration/targets/test_proxysql_backend_servers/tasks, but it's difficult to see through.
You can also just add a new taskfile in tests/integration/targets/test_proxysql_backend_servers/ and include it at the end of the main.yml