ansible-collections / community.proxysql

ProxySQL Ansible Collection
http://galaxy.ansible.com/community/proxysql
GNU General Public License v3.0
21 stars 26 forks source link

fix missing check_mode #138

Closed markuman closed 1 year ago

markuman commented 1 year ago
SUMMARY

Fixes #137
Fixes #131

ISSUE TYPE
COMPONENT NAME

proxysql_manage_config

codecov[bot] commented 1 year ago

Codecov Report

Merging #138 (c94de95) into main (4c7df75) will increase coverage by 1.36%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   75.14%   76.51%   +1.36%     
==========================================
  Files          10       11       +1     
  Lines        1199     1205       +6     
  Branches      193      194       +1     
==========================================
+ Hits          901      922      +21     
+ Misses        221      214       -7     
+ Partials       77       69       -8     
Flag Coverage Ξ”
integration 75.08% <75.00%> (?)
sanity 19.91% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
plugins/modules/proxysql_manage_config.py 71.42% <75.00%> (+0.59%) :arrow_up:
plugins/doc_fragments/proxysql.py 100.00% <0.00%> (ΓΈ)
plugins/modules/proxysql_query_rules.py 71.66% <0.00%> (+0.55%) :arrow_up:
...ugins/modules/proxysql_query_rules_fast_routing.py 86.74% <0.00%> (+0.60%) :arrow_up:
plugins/modules/proxysql_mysql_users.py 77.35% <0.00%> (+0.62%) :arrow_up:
plugins/modules/proxysql_backend_servers.py 71.69% <0.00%> (+0.62%) :arrow_up:
plugins/modules/proxysql_replication_hostgroups.py 82.39% <0.00%> (+0.70%) :arrow_up:
plugins/modules/proxysql_scheduler.py 80.31% <0.00%> (+0.78%) :arrow_up:
plugins/modules/proxysql_global_variables.py 75.30% <0.00%> (+1.23%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

patchback[bot] commented 1 year ago

Backport to stable-1: πŸ’š backport PR created

βœ… Backport PR branch: patchback/backports/stable-1/b14ca9f272cfe4a658a4c3e33261ee20a0323a9d/pr-138

Backported as https://github.com/ansible-collections/community.proxysql/pull/139

πŸ€– @patchback I'm built with octomachinery and my source is open β€” https://github.com/sanitizers/patchback-github-app.