fix(rabbitmq_plugin): add node to module args

ansible-collections / community.rabbitmq

Manage RabbitMQ with Ansible

http://galaxy.ansible.com/community/rabbitmq

Other

31 stars 50 forks source link

fix(rabbitmq_plugin): add node to module args #106

Open rockandska opened 3 years ago

rockandska commented 3 years ago

SUMMARY

Add node argument to rabbitmq_plugin the same way as other module ( close #59 )

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rabbitmq_plugin

ADDITIONAL INFORMATION

Integration test and unit test ok Minimal test added

ansible-test units --docker default -v --color --python 3.8
ansible-test integration rabbitmq_plugin --docker default -v --color --python 3.8

@odyssey4me / @Andersson007 : since #101 is still a WIP.

Regards,

rockandska commented 3 years ago

For an obscure reason, previously to ansible 2.12 if the node argument contain an @ as rabbibt@node-1, in cmd output the node is replaced with by '' but the error reflect that the argument -n rabbit@node-1 was provided.

I updated the test to remove @ and be able to test cmd, but there is definitely something odd

Im0 commented 3 years ago

@rockandska good one. Looks good to me. It would be great if you could add suggestions 1 & 2 from @Andersson007

rockandska commented 3 years ago

Done