search

ansible-collections / community.rabbitmq

Manage RabbitMQ with Ansible
http://galaxy.ansible.com/community/rabbitmq
Other
31 stars 46 forks source link

CI: add testing against ansible-core 2.13 #118

Closed csmart closed 2 years ago

csmart commented 2 years ago

This patch adds stable-2.13 to the testing matrix as it is now available for testing.

See https://github.com/ansible-collections/news-for-maintainers/issues/14

Closes #117

csmart commented 2 years ago

Hmmm.. CI is failing on StrictVersion, but the code that added it passed just fine... https://github.com/ansible-collections/community.rabbitmq/pull/115/checks

00:22 tests/unit/modules/test_rabbitmq_user.py:396: 
00:22 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
00:22 plugins/modules/rabbitmq_user.py:530: in main
00:22     if rabbitmq_user.get():
00:22 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
00:22 
00:22 self = <ansible_collections.community.rabbitmq.plugins.modules.rabbitmq_user.RabbitMqUser object at 0x7fcbc210a070>
00:22 
00:22     def get(self):
00:22         """Retrieves the list of registered users from the node.
00:22     
00:22         If the user is already present, the node will also be queried for the user's permissions and topic
00:22         permissions.
00:22         If the version of the node is >= 3.7.6 the JSON formatter will be used, otherwise the plaintext will be
00:22         parsed.
00:22         """
00:22 >       if self._version >= Version.StrictVersion('3.7.6'):
00:22 E       TypeError: '>=' not supported between instances of 'StrictVersion' and 'StrictVersion'
00:22 
00:22 plugins/modules/rabbitmq_user.py:321: TypeError
Andersson007 commented 2 years ago

The reason was that we forgot to change the import in unit tests. Solved by https://github.com/ansible-collections/community.rabbitmq/pull/115. Feel free to merge, then relaunch tests here.

Andersson007 commented 2 years ago

@csmart thank you!