search

ansible-collections / community.rabbitmq

Manage RabbitMQ with Ansible
http://galaxy.ansible.com/community/rabbitmq
Other
30 stars 46 forks source link

Fix sanity, remove EOL test targets #150

Closed Andersson007 closed 1 year ago

Andersson007 commented 1 year ago
SUMMARY

Fix sanity, remove EOL test targets

Andersson007 commented 1 year ago

ready for review

Andersson007 commented 1 year ago

@Im0 hi, could you please take a look? In particular, at plugins/modules/rabbitmq_publish.py. I'm removing the import detected as unused by sanity checks (so they are failing otherwise). If it's really needed, we could put it back and add another line in ignore-2.15.txt.

Andersson007 commented 1 year ago

@Im0 have you had a chance to take a look? if there are any concerns about the imports, we can leave them as is and add entries to ignore.txt to ignore this when passing sanity checks. Ideas? (fyi, i'll be on PTO next week, feel free to push to my PR and merge)

Im0 commented 1 year ago

@Andersson007 sorry, if you're still around, this looks good.

Andersson007 commented 1 year ago

@Im0 thanks for reviewing!