Closed Knalltuete5000 closed 1 week ago
@Knalltuete5000 hello, sorry for the late feedback, could you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment ?
Thanks for the feedback.
I have added the changelog-fragment to the commit.
As far as I can tell the pipeline fails because some packages cannot be installed. Is this correct or a known issue?
@Knalltuete5000 thanks for the contribution!
yes, the URLs don't work, we've briefly discussed it in https://github.com/ansible-collections/community.rabbitmq/pull/174#issuecomment-2435130990
If you know how to solve it, any help is much appreciated. Those URLs are located somewhere under tests/integration/targets
directory
How to run them locally can be found in https://docs.ansible.com/ansible/devel/community/create_pr_quick_start.html, but people can just push their PRs and see if there's any issue with local setup
If I'm not wrong the urls to install rabbitmq in the setup for the tests are outdated corresponding to the rabbitmq installation instructions. I think they have changed the link about a month or two ago which corresponds to the pipeline failing. I'm not sure if this is the solution for the problem but it might be worth to give it a try.
If I have the time and I get the tests running locally I will try it out later
@Knalltuete5000 sure, sounds great, thanks a lot for the desire to help here!
SUMMARY
Adjust the apply_to parameter of the rabbitmq_policy module to accept also classic_queues, quorum_queues and streams which are supported since rabbitmq 3.12
Fixes #167
ISSUE TYPE
COMPONENT NAME
community.rabbitmq.rabbitmq_policy