ansible-collections / community.rabbitmq

Manage RabbitMQ with Ansible
http://galaxy.ansible.com/community/rabbitmq
Other
31 stars 46 forks source link

Improve integration testing #79

Open Andersson007 opened 3 years ago

Andersson007 commented 3 years ago
SUMMARY

To make things going in the collection, CI, that failed, was simplified with https://github.com/ansible-collections/community.rabbitmq/pull/78

I can't invest much time as not a maintainer of this collection and not a specialist in the area.

Would be nice:

  1. Get rid of the simplification introduced with https://github.com/ansible-collections/community.rabbitmq/pull/78 replacing it with corresponding Ansible tasks. Uncomment # - stage: Docker_2_9 in .azure-pipelines/azure-pipelines.yml

  2. Add ubuntu 16.04 back to .azure-pipelines/azure-pipelines.yml against to all the branches except devel

  3. The CI triggers many distributions (like Fedora, CentOS, Suse, etc.) but tests actually run only on Ubuntu. I disabled them to reduce load on CI system. We could a) remove them from the test matrix or b) implement tests for them (for what? I think rabbitmq versions are actually important)

  4. Would be nice to run tests against several versions of rabbitmq (starting with the oldest supported and finishing with the latest one).

Andersson007 commented 3 years ago

cc @cognifloyd Let's track the progress in this issue

petebuffon commented 2 years ago

I'm currently in the process of adding ansible-collections-community-rabbitmq to both Fedora and CentOS. It would help me out if there were tests for both of these distributions.

I would be willing to help write these tests, but I'm not exactly sure where to start.

Andersson007 commented 2 years ago

@petebuffon hello, thanks for your interest! You could start with:

If there are any questions, feel free to ask, thanks!

Im0 commented 1 year ago

Might be worth considering removing shippable/posix like in https://github.com/ansible-collections/community.docker/pull/484 and perhaps some of utils/shippable could be tidied up? (Check other repo's)

Andersson007 commented 1 year ago

Might be worth considering removing shippable/posix like in ansible-collections/community.docker#484 and perhaps some of utils/shippable could be tidied up? (Check other repo's)

Sure

Im0 commented 1 year ago

4. Would be nice to run tests against several versions of rabbitmq (starting with the oldest supported and finishing with the latest one).

To this point. Perhaps we should test 3.9, 3.10 and 3.11 of rabbitmq. Details here: https://www.rabbitmq.com/versions.html Or, just test 3.9 and 3.11?

Something to be mindful of is the different erlang requirements for different versions: https://www.rabbitmq.com/which-erlang.html

Im0 commented 1 year ago

@Andersson007 are most collections utilising github workflows these days? Is it strange/undesirable for community.rabbitmq to be using AZP? Or OK?

Andersson007 commented 1 year ago

@Im0 it's OK