ansible-collections / community.rabbitmq

Manage RabbitMQ with Ansible
http://galaxy.ansible.com/community/rabbitmq
Other
31 stars 50 forks source link

Add module: rabbitmq_upgrade #83

Closed damiandabrowski5 closed 3 years ago

damiandabrowski5 commented 3 years ago
SUMMARY

module: rabbitmq_upgrade short_description: Execute rabbitmq-upgrade commands description: Allows to execute rabbitmq-upgrade commands options:

ISSUE TYPE
COMPONENT NAME

rabbitmq_upgrade

Andersson007 commented 3 years ago

Please fix the test errors. Click "Details" in the test box for details.

damiandabrowski5 commented 3 years ago

@damiandabrowski5 hi, thanks for the module.

Is this a kind of command simplification? Just the same as we can run via CLI?

Generally not idempotent solutions are not welcome but if the RabbitMQ community thinks that this is worthwhile and makes life much easier, they can decide.

I left a couple of general notes.

I wrote this module because it was frustrating to drain&revive nodes via CLI every time(and also check if maintenance_mode_status is enabled)

The rest of available actions(await_online_quorum_plus_one, await_online_synchronized_mirror, post_upgrade) were added just to have all rabbitmq-upgrade commands covered. But I'm pretty sure, they should always return 'changed' or just 'OK'.

I've added Your suggestions, now we have all checks passed.

Andersson007 commented 3 years ago

@damiandabrowski5 thanks for the new module! Would be great if you continue the contribution to the project! @odyssey4me thanks for reviewing!