search

ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
95 stars 45 forks source link

Fix for "'VersionedAPIData' object has no attribute 'fully_supported'" #219

Closed hansmi closed 12 months ago

hansmi commented 1 year ago
SUMMARY

Commit 4b09951 added code looking for a non-existent fully_supported attribute.

ISSUE TYPE
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (81c4186) 83.15% compared to head (7b7ad0e) 83.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #219 +/- ## ======================================= Coverage 83.15% 83.15% ======================================= Files 32 32 Lines 4031 4031 Branches 867 867 ======================================= Hits 3352 3352 Misses 494 494 Partials 185 185 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `66.86% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.12% <0.00%> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `83.10% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/\_api\_data.py](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvX2FwaV9kYXRhLnB5) | `69.38% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hansmi commented 1 year ago

@felixfontein, I'm not familiar with the details of the modified code, let alone the tests which codecov complains about ("plugins/module_utils/_api_data.py#L62: Added line #L62 was not covered by tests"). Feel free to close this PR if you can fix the problem in another way.

felixfontein commented 12 months ago

@hansmi thanks for fixing this! The codecov warning basically shows that this wasn't covered by tests, but that was already happening before this PR.