search

ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
102 stars 46 forks source link

Fix some bugs and adapt RouterOS v.7.12 changes #234

Closed derdeagle closed 11 months ago

derdeagle commented 11 months ago

/ip traffic-flow target: make it a multiple value (single_value=False) field /routing id: add comment attribute /tool e-mail: add versioning to the parameters as "address" was renamed to "server" in 7.12 /routing bgp connection: add missing attributes

SUMMARY

/ip traffic-flow target: make it a multiple value (single_value=False) field /routing id: add comment attribute /tool e-mail: add versioning to the parameters as "address" was renamed to "server" in 7.12 /routing bgp connection: add missing attributes

ISSUE TYPE
COMPONENT NAME

api_data

ADDITIONAL INFORMATION
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1beddb5) 83.15% compared to head (5c2870e) 83.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #234 +/- ## ======================================= Coverage 83.15% 83.15% ======================================= Files 32 32 Lines 4031 4031 Branches 867 867 ======================================= Hits 3352 3352 Misses 494 494 Partials 185 185 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `66.86% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.12% <ø> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `83.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/\_api\_data.py](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvX2FwaV9kYXRhLnB5) | `69.38% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

derdeagle commented 11 months ago

@felixfontein Thank you very much for your review. I addressed or at least answered on your comments.

felixfontein commented 11 months ago

@derdeagle thanks for your improvements!