search

ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
95 stars 44 forks source link

Change ip vrf for router OS v7 #259

Closed liquorice-head closed 6 months ago

liquorice-head commented 7 months ago
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
In router OS 7, the path to vrf and the fields used have changed
tested on v7.13.3
github-actions[bot] commented 7 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.routeros/branch/main

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (542a362) 82.97% compared to head (05d64c6) 82.97%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #259 +/- ## ======================================= Coverage 82.97% 82.97% ======================================= Files 32 32 Lines 4046 4046 Branches 871 871 ======================================= Hits 3357 3357 Misses 506 506 Partials 183 183 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/259/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/259/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `66.86% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/259/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.10% <ø> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/259/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `82.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ialshaev commented 7 months ago

@felixfontein is it possible to have both versions for vrf path? So we can decide what path to chose depending on RouterOS version. Thank you in advance!

felixfontein commented 7 months ago

@ialshaev yes, simply keep the old path and add a new one. Using versioning you should be able to say that the old one only works before version x.y, and the new one only with version x.y and newer.

liquorice-head commented 6 months ago

Added versioning. Pls review

liquorice-head commented 6 months ago

Done. Please review

felixfontein commented 6 months ago

@liquorice-head thanks for implementing this! @derdeagle thanks for reviewing this!

derdeagle commented 6 months ago

Always a pleasure ;)