search

ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
98 stars 45 forks source link

KeyInfo: prevent read_only usage with can_disable, remove_value, absent_value, default, or required #265

Closed felixfontein closed 7 months ago

felixfontein commented 7 months ago
SUMMARY

Ref: https://github.com/ansible-collections/community.routeros/pull/264#issuecomment-1975073650

ISSUE TYPE
COMPONENT NAME

_api_data.py

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.99%. Comparing base (8400926) to head (901b6e0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #265 +/- ## ========================================== + Coverage 82.97% 82.99% +0.02% ========================================== Files 32 32 Lines 4046 4051 +5 Branches 871 873 +2 ========================================== + Hits 3357 3362 +5 Misses 506 506 Partials 183 183 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `66.86% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.08% <0.00%> (-0.03%)` | :arrow_down: | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `82.93% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felixfontein commented 7 months ago

@derdeagle thanks for reviewing this!