ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
95 stars 44 forks source link

Fix IPv6 address 'from-pool' default value #270

Closed samburney closed 4 months ago

samburney commented 5 months ago
SUMMARY

When not set, the RouterOS API always returns the IPv6 Address 'from-pool' value as '', however _api_data.py has no default value set.

This PR fixes this issue.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION

Test task:

  tasks:
    - name: Add IPv6 address with defaults
      community.routeros.api_modify:
        path: ipv6 address
        handle_absent_entries: remove
        handle_entries_content: remove
        data:
          - address: fedc:1234:5678:abcd::1/64
            interface: ether1

Output from api_info:

TASK [Print output of queue_simple_api_info] **************************************************************************************************************************************
ok: [testrtr1] => {
    "queue_simple_api_info": {
        "changed": false,
        "failed": false,
        "result": [
            {
                "!comment": null,
                ".id": "*9",
                "address": "fedc:1234:5678:abcd::1/64",
                "interface": "ether1"
            }
        ]
    }
}

Before change:

TASK [Add IPv6 address with defaults] *********************************************************************************************************************************************
--- before
+++ after
@@ -1,14 +1,8 @@
 {
     "data": [
         {
-            ".id": "*9",
             "address": "fedc:1234:5678:abcd::1/64",
-            "advertise": true,
-            "disabled": false,
-            "eui-64": false,
-            "from-pool": "",
-            "interface": "ether1",
-            "no-dad": false
+            "interface": "ether1"
         }
     ]
 }

changed: [testrtr1]

After change:

TASK [Add IPv6 address with defaults] *********************************************************************************************************************************************
ok: [testrtr1]
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.99%. Comparing base (a3fbe88) to head (f5c1b4b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 82.99% 82.99% ======================================= Files 32 32 Lines 4051 4051 Branches 873 873 ======================================= Hits 3362 3362 Misses 506 506 Partials 183 183 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `66.86% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.08% <ø> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `82.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felixfontein commented 4 months ago

@samburney thanks again!

github-actions[bot] commented 4 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.routeros/branch/main