ansible-collections / community.routeros

Ansible modules for managing MikroTik RouterOS instances.
https://galaxy.ansible.com/ui/repo/published/community/routeros/
GNU General Public License v3.0
98 stars 45 forks source link

Add RouterOS 6.x support for '/ip route rule' path #278

Closed vint2k closed 6 months ago

vint2k commented 6 months ago
SUMMARY

Support API path '/ip route rule' for RouterOS 6.x

ISSUE TYPE
COMPONENT NAME
github-actions[bot] commented 6 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.routeros/branch/main

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.08%. Comparing base (8351bff) to head (be8546f). Report is 7 commits behind head on main.

:exclamation: Current head be8546f differs from pull request most recent head 7ea371d. Consider uploading reports for the commit 7ea371d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## =========================================== - Coverage 82.99% 22.08% -60.91% =========================================== Files 32 18 -14 Lines 4051 2196 -1855 Branches 873 576 -297 =========================================== - Hits 3362 485 -2877 - Misses 506 1683 +1177 + Partials 183 28 -155 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `?` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `22.08% <ø> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.routeros/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vint2k commented 6 months ago

done

felixfontein commented 6 months ago

@vint2k thanks again!