ansible-collections / community.vmware

Ansible Collection for VMware
GNU General Public License v3.0
343 stars 336 forks source link

No Timeout in vmware_guest_info #662

Open phgogo opened 3 years ago

phgogo commented 3 years ago
SUMMARY

When using vmware_guest_info, we ran into situations where the module does not return results for hours or days. We have a scheduled job, that uses the module to receive VM Informations every night, where it sometimes "get stuck". As there is no timeout, we don't know if it's a network issue or a programmatic error.

ISSUE TYPE
COMPONENT NAME

vmware_guest_info

ANSIBLE VERSION
CONFIGURATION
- name: Get current VC-Tags
  community.vmware.vmware_guest_info:
    name: "{{ inventory_hostname }}"
    datacenter: ""
    tags: yes
    hostname: '{{ vcenter_host }}'
    username: '{{ lookup("env", "VMWARE_USER") }}'
    password: '{{ lookup("env", "VMWARE_PASSWORD") }}'
    validate_certs: '{{ vc_cert_validation }}'
  delegate_to: some_server
  register: vc_tags_old
  throttle: 29
EXPECTED RESULTS

Their should be a timeout with a meaningful error message, stating if the error is related to network issues or e.g. an unterminating loop inside the module.

ACTUAL RESULTS

The module does not return anything unless manually stopped.

ansibullbot commented 3 years ago

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot commented 3 years ago

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pgbidkar @warthog9 click here for bot help