search

ansible-collections / community.windows

Windows community collection for Ansible
https://galaxy.ansible.com/community/windows
GNU General Public License v3.0
199 stars 153 forks source link

Fix CNAME creation in win_dns_record #452

Closed JLE-ATS closed 1 year ago

JLE-ATS commented 1 year ago
SUMMARY

As suggested in https://github.com/ansible-collections/community.windows/issues/429, I have added a case to handle CNAME creation when the cname is part of a subdomain. This is my first contribution and I am not used to the contribution process, so I am sorry if this is not the right way to submit fixes.

Fixes #429

ISSUE TYPE
COMPONENT NAME

win_dns_record

ADDITIONAL INFORMATION

If this fix is accepted, the documentation should be updated with instructions for creating aliases in subdomains. Unfortunately, I didn't find where I could update the documentation in this repository. The following task could be included in the examples on the documentation page :

- name: Create the alias helloworld.test.example.com pointing to myserver.example.com
    community.windows.win_dns_record:
      name: "helloworld.test"
      type: "CNAME"
      value: "myserver.example.com"
      zone: "example.com"
jborean93 commented 1 year ago

Just closing and re-opening to clear out the CI problems.

jborean93 commented 1 year ago

Ignore the sanity failure, it will be fixed with https://github.com/ansible-collections/community.windows/pull/454 and is unrelated to your changes here.