ansible-collections / community.windows

Windows community collection for Ansible
https://galaxy.ansible.com/community/windows
GNU General Public License v3.0
198 stars 153 forks source link

Fix program can't be set to any #472

Closed PfurtschellerP closed 1 year ago

PfurtschellerP commented 1 year ago

If ApplicationName of an existing rule should be set to any the parameter has to be set to $null which is not allowed. In these cases Set-NetFirewallRule can be used to set the parameter Program to "any" which translates to setting the ApplicationName of the rule to $null.

SUMMARY
ISSUE TYPE
COMPONENT NAME

win_firewall_rule

ADDITIONAL INFORMATION

https://github.com/ansible-collections/community.windows/issues/471

codecov[bot] commented 1 year ago

Codecov Report

Merging #472 (f9157ed) into main (d1edb78) will increase coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head f9157ed differs from pull request most recent head b079b86. Consider uploading reports for the commit b079b86 to get more accurate results

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   69.18%   69.22%   +0.03%     
==========================================
  Files         204      204              
  Lines       10814    10807       -7     
  Branches      150      150              
==========================================
- Hits         7482     7481       -1     
+ Misses       3323     3317       -6     
  Partials        9        9              
Impacted Files Coverage Δ
plugins/modules/win_dns_record.py 100.00% <ø> (ø)
plugins/modules/win_dns_record.ps1 95.68% <100.00%> (+7.07%) :arrow_up:
plugins/modules/win_partition.ps1 83.51% <100.00%> (ø)
plugins/modules/win_psscript.ps1 90.10% <0.00%> (-1.10%) :arrow_down:
plugins/modules/win_psmodule.ps1 81.78% <0.00%> (-0.78%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

PfurtschellerP commented 1 year ago

@jborean93 is this now correct?