search

ansible-collections / community.windows

Windows community collection for Ansible
https://galaxy.ansible.com/community/windows
GNU General Public License v3.0
198 stars 153 forks source link

Append custom LDAP attributes to the module Result object #481

Closed pierre-claranet closed 1 year ago

pierre-claranet commented 1 year ago
SUMMARY

Append attributes present in attributes option, with their value, to the module output.

ISSUE TYPE
COMPONENT NAME

win_domain_user

ADDITIONAL INFORMATION
jborean93 commented 1 year ago

Sorry for the delay in reviewing the PR. Unfortunately this module is ultimately going to be deprecated and removed at a future point in time in favour of microsoft.ad.user module. While the collection is not live yet it is designed to be a supported collection for all things Active Directory.

In saying that, one of the features that the new module is moving away from is returning all the results about a user object back to the user. This is done to make the modules simpler in operation, especially around check mode, and the recommended approach is to use the microsoft.ad.object_info module to return the attributes you desire. There's even a copy of object_info in this module which can be used today.

pierre-claranet commented 1 year ago

Ok, sorry, I wasn't aware of this...

Thanks for the info about the new collection and its object_info module, we'll switch to it.