ansible-collections / community.windows

Windows community collection for Ansible
https://galaxy.ansible.com/community/windows
GNU General Public License v3.0
198 stars 153 forks source link

feat(win_domain_computer,win_domain_object_info): add activedirectory module import #509

Closed gotit96 closed 1 year ago

gotit96 commented 1 year ago
SUMMARY

This proposed change, add explicit import of ActiveDirectory module in win_domain_computer and win_domain_object_info.

fix #469

ISSUE TYPE
COMPONENT NAME

win_domain_computer win_domain_object_info

ADDITIONAL INFORMATION

This change allow this module to run on server with automatic import of modules disabled. And improve error message when ActiveDirectory module is missing.

jborean93 commented 1 year ago

Thanks for adding this. Just as an FYI these modules are planned to be deprecated shortly in favour of the ones in microsoft.ad. The microsoft.ad collection is a supported collection unlike this one which is just community maintained. If you do see any problems there we are happy to accept a PR like this one.