search

ansible-collections / community.yang

Ansible Community Collection to support Yang in network devices.
GNU General Public License v3.0
10 stars 14 forks source link

Remove tests/sanity/requirements.txt #54

Closed Andersson007 closed 3 years ago

Andersson007 commented 3 years ago
SUMMARY

https://github.com/ansible-collections/overview/issues/43

gundalow commented 3 years ago

recheck

Andersson007 commented 3 years ago

we are getting:

  1. ansible-tox-linters errors
  2. and the following ansible-test-network-integration-community-yang-iosxr-netconf-python36 error 
    2021-03-03 14:40:23.564871 | centos-8 | TASK [fetch : Fetch base and dependant openconfig-interfaces yang data models] ***
2021-03-03 14:40:23.565222 | centos-8 | task path: /home/zuul/.ansible/collections/ansible_collections/community/yang/tests/integration/targets/fetch/tests/iosxr/basic.yaml:5
2021-03-03 14:40:23.623721 | centos-8 | <10.21.32.50> attempting to start connection
2021-03-03 14:40:23.624363 | centos-8 | <10.21.32.50> using connection plugin ansible.netcommon.netconf
2021-03-03 14:40:23.624694 | centos-8 | Found ansible-connection at path /home/zuul/venv/bin/ansible-connection
2021-03-03 14:40:24.752921 | centos-8 | <10.21.32.50> found existing local domain socket, using it!
2021-03-03 14:40:24.752978 | centos-8 | [WARNING]: Persistent connection logging is enabled for 10.21.32.50. This will
2021-03-03 14:40:24.752989 | centos-8 | log ALL interactions to /home/zuul/ansible-debug.txt and WILL NOT redact
2021-03-03 14:40:24.752997 | centos-8 | sensitive configuration like passwords. USE WITH CAUTION!
2021-03-03 14:40:24.753005 | centos-8 | <10.21.32.50>
2021-03-03 14:40:24.753012 | centos-8 | <10.21.32.50> local domain socket path is /home/zuul/.ansible/pc/0f121e99ec
2021-03-03 14:40:29.134222 | centos-8 | The full traceback is:
2021-03-03 14:40:29.134286 | centos-8 | Traceback (most recent call last):
2021-03-03 14:40:29.134303 | centos-8 |   File "/tmp/ansible-test-1v3k517r/ansible/executor/task_executor.py", line 159, in run
2021-03-03 14:40:29.134313 | centos-8 |     res = self._execute()
2021-03-03 14:40:29.134320 | centos-8 |   File "/tmp/ansible-test-1v3k517r/ansible/executor/task_executor.py", line 574, in _execute
2021-03-03 14:40:29.134328 | centos-8 |     result = self._handler.run(task_vars=variables)
2021-03-03 14:40:29.134336 | centos-8 |   File "/home/zuul/.ansible/collections/ansible_collections/community/yang/plugins/action/fetch.py", line 108, in run
2021-03-03 14:40:29.134343 | centos-8 |     capabilities = json.loads(conn.get_capabilities())
2021-03-03 14:40:29.134350 | centos-8 |   File "/tmp/ansible-test-1v3k517r/ansible/module_utils/connection.py", line 195, in __rpc__
2021-03-03 14:40:29.134357 | centos-8 |     raise ConnectionError(to_text(msg, errors='surrogate_then_replace'), code=code)
2021-03-03 14:40:29.134380 | centos-8 | ansible.module_utils.connection.ConnectionError: Unexpected session close
2021-03-03 14:40:29.135125 | centos-8 | fatal: [iosxr-6.1.3]: FAILED! => {
2021-03-03 14:40:29.135149 | centos-8 |     "msg": "Unexpected failure during module execution.",
2021-03-03 14:40:29.135158 | centos-8 |     "stdout": ""
2021-03-03 14:40:29.135165 | centos-8 | }
rohitthakur2590 commented 3 years ago

@Andersson007 Thanks for the PR, could you please run tox -eblack for ansible-tox-linters test fails

Andersson007 commented 3 years ago

@rohitthakur2590 yw! i don't understand, sorry, could you please explain what i should do in other words?

rohitthakur2590 commented 3 years ago

@rohitthakur2590 yw! i don't understand, sorry, could you please explain what i should do in other words?

so for linter failures, you can run command tox -eblack on the yang repo for formatting to get rid of https://657aab01354669666010-cd53e4c25a35c9be913c75e02548ac2a.ssl.cf1.rackcdn.com/54/e4ada2ae620ae6a4aa45208d621cc0603108c039/check/ansible-tox-linters/7635461/job-output.html#l659

Andersson007 commented 3 years ago

@rohitthakur2590 done, thanks!

Andersson007 commented 3 years ago

green now ready_for_review

Andersson007 commented 3 years ago

@gundalow @rohitthakur2590 @ganeshrn thanks for reviewing!

Andersson007 commented 3 years ago

:+1: