Refactor zabbix web - Githubissues

ansible-collections / community.zabbix

Zabbix Ansible modules

http://galaxy.ansible.com/community/zabbix

Other

321 stars 280 forks source link

Refactor zabbix web #1235

Closed eb4x closed 3 months ago

eb4x commented 4 months ago

SUMMARY

This is a refactor of the zabbix_web role.

ISSUE TYPE

Refactor Pull Request

COMPONENT NAME

zabbix_web role

ADDITIONAL INFORMATION

Some small fixes to zabbix_server role, zabbix_web uses a more recent version of mysql, which uncovered some issues with pymysql.

eb4x commented 4 months ago

I'm posting this as a draft, I haven't figured it all out yet. There are some things that don't really line up between the os_families. Like why are php packages installed for debian, but redhat packages goes unused.

eb4x commented 3 months ago

I'm taking this out of draft. I think the changes here are good cleanups. Not really done yet, but if merged, I'll create a new PR with the rest of the changes for this refactor. (otherwise I'll push to this when ready.)

pyrodie18 commented 3 months ago

You good for me to pull this in @eb4x

eb4x commented 3 months ago

Yep just merge if you feel like. I can create a second PR once I figure out how to strip the last bits in tasks/RedHat.yml. I think these are all good parts of the refactor.