search

ansible-collections / community.zabbix

Zabbix Ansible modules
http://galaxy.ansible.com/community/zabbix
Other
321 stars 280 forks source link

Wrong include dir is being removed here #1236

Closed badfiles closed 3 months ago

badfiles commented 4 months ago

This line removes agent II include dir trying to remove agent I include dir

https://github.com/ansible-collections/community.zabbix/blob/64b6687b9a6763c1987902aec05244db02e6e75d/roles/zabbix_agent/tasks/remove.yml#L23

derekpurdy commented 4 months ago

I'm having the same issue, it seems to break zabbix_agent2 from being able to start as "/etc/zabbix/zabbix_agent2.d" is missing.

Jun 2 09:58:36 zabbix zabbix_agent2[1122563]: zabbix_agent2 [1122563]: ERROR: Cannot read configuration: cannot include "/etc/zabbix/zabbix_agent2.d": stat /etc/zabbix/zabbix_agent2.d: no such file or directory

derekpurdy commented 3 months ago

it does seem like a show stopper, it basically breaks zabbix_agent2 from working out of the box without manually modifying the remove task in the collection (or modifying the template conf file to not include an include line.)

krauthosting commented 3 months ago

@pyrodie18 Same as #1263 will this be backported to stable point release 2.5.1? git cherry-pick 3f38086

pyrodie18 commented 3 months ago

No, as a collection we're only maintaining the current version and not previous versions.