ansible-collections / community.zabbix

Zabbix Ansible modules
http://galaxy.ansible.com/community/zabbix
Other
315 stars 265 forks source link

zabbix_agent - Use zabbix_agent_distribution_release to backport packages #1240

Open kivilahtio opened 1 month ago

kivilahtio commented 1 month ago
SUMMARY

Configuration 'zabbix_agent_distribution_release' is already defined in the role. Actually make it usable to overload the system's ansible_distribution_release. This is useful to for example install Zabbix Agent2 on Raspbian 12 Bookworm using the older packages, as there is not release for the specific target distribution and version.

ISSUE TYPE
COMPONENT NAME

Zabbix Agent

ADDITIONAL INFORMATION
kivilahtio commented 1 month ago

Unrelated to this: I delivered a PR to address an architecture issue I encountered with the Raspbian support:

https://github.com/ansible-collections/community.zabbix/pull/1060

It is closed, but maybe it can be reopened to continue the discussion as there is an update to the previously fixed issue?

pyrodie18 commented 1 month ago

I don't see where zabbix_agent_distribution_release is defined anywhere.

kivilahtio commented 1 month ago

I don't see where zabbix_agent_distribution_release is defined anywhere.

commit f008e178bf0fa31fb74cbcc96054a8d8feee3094 Author: Werner Dijkerman werner.dijkerman@iwelcome.com Date: Tue Jun 9 19:02:50 2020 +0200

As it provides error while using a dash (-) in the role name, we will use an underscore (_)

file: roles/zabbix_agent/defaults/main.yml

eb4x commented 1 month ago

Unrelated to this: I delivered a PR to address an architecture issue I encountered with the Raspbian support:

1060

It is closed, but maybe it can be reopened to continue the discussion as there is an update to the previously fixed issue?

I think you'll find that #1225 fixes what #1060 wanted to do. But you're probably right that Suites: should be based on the lsb.id.

That's not what's going down in this PR though, you'll have to update to reflect the newest changes.

eb4x commented 1 month ago

But you're probably right that Suites: should be based on the lsb.id.

Actually, it should probably just say zabbix here? Looking at https://repo.zabbix.com/zabbix/6.4/raspbian/dists/bullseye/Release Suite: zabbix, or maybe it doesn't really matter?