search

ansible-collections / community.zabbix

Zabbix Ansible modules
http://galaxy.ansible.com/community/zabbix
Other
315 stars 265 forks source link

Tags in LLD rules #1269

Closed BGmot closed 4 weeks ago

BGmot commented 4 weeks ago

Hi @aplathrop , can you please clarify where these tags should go to? https://github.com/ansible-collections/community.zabbix/blob/main/plugins/modules/zabbix_discoveryrule.py#L228 I cannot find this neither in UI nor in API documentation for 6.4. It is failing for 7.0 as it has stricter parameters check.

aplathrop commented 4 weeks ago

That looks like I copy-pasted the examples I wrote for zabbix_item (their API methods are surprisingly similar) and didn't delete the tags from the item module. I can submit a PR to change that example to something that works if you would like

BGmot commented 4 weeks ago

Thanks for looking into this so quickly. Yes, please update EXAMPLES section and tests as well (in a PR).

BGmot commented 4 weeks ago

Also please mention somewhere in documentation that this is LLD discovery rules