Re-added additional include for agent

ansible-collections / community.zabbix

Zabbix Ansible modules

http://galaxy.ansible.com/community/zabbix

Other

315 stars 265 forks source link

Re-added additional include for agent #1316

Open Thulium-Drake opened 2 days ago

Thulium-Drake commented 2 days ago

SUMMARY

This PR restores #1059 to version 3.0.0 of the collection.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

zabbix_agent role

ADDITIONAL INFORMATION

This was originally added in #1059 but lost when making version 3.0.0 with the revamped config file for the agent.

pyrodie18 commented 1 day ago

We're already including everything in /etc/zabbix/zabbix_agent2.d. Is there a reason that isn't sufficient?

Thulium-Drake commented 1 day ago

No, because, what's also mentioned in #1056 , the includes are not recursive, each directory much be included on it's own. And the default installation directory for all Zabbix Agent2 Plugins is /etc/zabbix/zabbix_agent2.d/plugins.d.

pyrodie18 commented 10 hours ago

OK fair. That being the case, I would do this like how we currently handle alias instead of having include and include_additional.