ansible-collections / dellemc.os10

GNU General Public License v3.0
37 stars 49 forks source link

LAG Interfaces cannot support "no negotiation" command #104

Open FredPocai opened 2 years ago

FredPocai commented 2 years ago

If the dictionary does not have "auto_neg" defined, it is defaulting to add "no negotiation". This command is not supported on LAG interfaces.

https://github.com/ansible-collections/dellemc.os10/blob/9946fc3c2feb577afabfcf733d429d9b149452e7/roles/os10_interface/templates/os10_interface.j2#L141-L142

I have remedied this on a local copy by removing these two lines.

florath commented 2 years ago

Same here. The patch breaks my playbooks using port-channels: https://github.com/ansible-collections/dellemc.os10/commit/88bccbb75e557e6e73a321e2e21443ce256f169a

prasadapr commented 2 years ago

Hi @florath, sure will check and update. meanwhile Please can you share your playbook and output of the execution.

florath commented 2 years ago

Sorry - but I am not able to share my playbook / variable definition.

But it should very easy to reproduce: create a port channel using os10_interface.

prasadapr commented 2 years ago

Ok thanks @florath, will check and update.

woyteck1 commented 2 years ago

Same here. The patch breaks my playbooks using port-channels: 88bccbb

fatal: [sw4]: FAILED! => changed=false
  command: no negotiation
  msg: |-
    no negotiation
    % Error: Unrecognized command.
    sw4(conf-if-po-1)#
  rc: -32603
woyteck1 commented 2 years ago

I can share parts of my playbook, host config:

os10_interface:
  port-channel 1:
    desc: To-Dell-100G
    admin: up
    switchport: true
    mtu: 9216

  ethernet 1/1/31:
    desc: "To-Dell-p53-A"
    admin: up
    switchport: false
    flowcontrol:
      mode: "receive"
      enable: "off"
      state: "present"

  ethernet 1/1/32:
    desc: "To-Dell-p54-B"
    admin: up
    switchport: false
    flowcontrol:
      mode: "receive"
      enable: "off"
      state: "present"

os10_lag:
  Po 1:
    type: dynamic
    min_links: 1
    max_bundle_size: 2
    lacp_system_priority: 2
    channel_members:
      - port: ethernet 1/1/31
        mode: "active"
        port_priority: 3
        lacp_rate_fast: true
      - port: ethernet 1/1/32
        mode: "active"
        port_priority: 3
        lacp_rate_fast: true
    state: present
prasadapr commented 2 years ago

Hi @woyteck1, thanks for sharing the host config file for interface and lag. I am working on this and will update my observations with in a day or two.