search

ansible-collections / dellemc.os10

GNU General Public License v3.0
37 stars 49 forks source link

dellemc.os10 1.1.0 contains a breaking change preventing it's inclusion in Ansible 2.10.5 #61

Open dmsimard opened 3 years ago

dmsimard commented 3 years ago
SUMMARY

When building and packaging Ansible 2.10.5 we noticed that dellemc.os10 1.1.0 contains a breaking change as written in https://github.com/ansible-collections/dellemc.os10/blob/master/changelogs/CHANGELOG.rst#breaking-changes-porting-guide

As per semantic versioning, we are avoiding breaking changes until Ansible 3.0.0 where we could include this new release. You can see the versioning guidelines in the collection requirements here: https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#versioning-and-deprecation

For now we are staying with version 1.0.2.

ISSUE TYPE
EXPECTED RESULTS

Breaking changes should have been included in a version 2.0 of dellemc.os10, not a version 1.1.0.

gunasekaran-t commented 3 years ago

@dmsimard , The breaking changes mentioned as part of Changelog are only a minor part of one specific role out of other ~30 roles part of this collection. So we retained the same major number. We will try to update the number in next release time. Could you please share when is the Ansible 3.0.0 is planned to be released. If possible we would like to see the latest version dellemc.os10 to be part of next Ansible release. Please let us know if we can do anything for the same.

tadeboro commented 3 years ago

The breaking changes mentioned as part of Changelog are only a minor part of one specific role out of other ~30 roles part of this collection. So we retained the same major number.

This is not how semver works. If you do not want to bump your major version number, you need to make sure all existing playbooks still work. If this is not true, you need to release a new major version of the project.

I would suggest that you release a 2.0.0 as soon as possible since this bug not only affects ansible package, it will also break end-user setups where the collection is pinned (for example, users using dellemc.os:<2.0.0).

dmsimard commented 3 years ago

Could you please share when is the Ansible 3.0.0 is planned to be released.

3.0 is expected in February -- I recommend subscribing to the bullhorn newsletter so you can stay up to date with key dates: https://us19.campaign-archive.com/?u=56d874e027110e35dea0e03c1&id=0884f473d6