search

ansible-collections / google.cloud

GCP Ansible Collection https://galaxy.ansible.com/google/cloud
https://cloud.google.com
GNU General Public License v3.0
99 stars 126 forks source link

chore: fix gcp_sql_database integration test #604

Closed SirGitsalot closed 10 months ago

SirGitsalot commented 10 months ago

For MySQL 8.x "utf8" really mean "utf8mb3" and when you request utf8 as the charset, utf8mb3 is what's returned. Thanks to that, instead of being a no-op the "create a database that already exists" test attempts to update the database and fails rather than seeing that the database exists and is in the correct configuration. The fix here is to use a valid character set (utf8mb4 is the recommended encoding).

SirGitsalot commented 10 months ago

With this and #602 the tests are green (phew).

There's a few tests that were disabled due to flakiness, but so far those seems to be API issues rather than problems with the Ansible module. I'm going to try to get those running reliably and update the version(s) of Ansible we're testing against next.