Generate diff for all modules - Githubissues

ansible-collections / hetzner.hcloud

A collection to manage resources on Hetzner Cloud

https://galaxy.ansible.com/ui/repo/published/hetzner/hcloud

GNU General Public License v3.0

100 stars 35 forks source link

Generate diff for all modules #440

Open jooola opened 5 months ago

jooola commented 5 months ago

SUMMARY

Ansible is capable of printing diffs for before and after a module has run.

https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_checkmode.html#using-diff-mode

None of our modules implement this feature, which can be handy.

ISSUE TYPE

Feature Idea

ADDITIONAL INFORMATION

Most of the following steps are already implemented for the logic of our modules, only a few are missing to implement the diff:

Fetch the current state of the resource
TODO: Generate the result of the previous state and save it
Apply the requested changes if any, or create the resource if non-existent
TODO: Generate the result of the after state and save it
Generate the result of the state and return to the user

To simplify the implementation, a refactor might be needed to use the same structure on all our modules.

github-actions[bot] commented 2 months ago

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.