search

ansible-collections / ibm.spectrum_virtualize

IBM Spectrum Virtualize
GNU General Public License v3.0
21 stars 26 forks source link

Support ibm_svc_vdisk.iogrp and ibm_svc_vol_map.scsi #18

Closed freedge closed 2 years ago

freedge commented 4 years ago

SUMMARY

Can you please support some extra parameters such as io group for volumes, and scsi lun ID for volume mapping.

Ideally the ansible module should just support the full list of options that the cli provides :) but these are definitely my top 2

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION

Expecting module to look like this:

      ibm_svc_vdisk:
        clustername: '{{ svc_ip }}'
        username: "{{ svcuser }}"
        password: "{{ svcpassword }}"
        log_path: /tmp/playbook.debug
        name: "{{ volume_name }}"
        state: present
        mdiskgrp: '{{ svc_pool }}'
        easytier: 'on'
        autoexpand: 'on'
        size: "200"
        unit: gb
        iogrp: io_grp0  # XXX

    - name: Map volume to host
      delegate_to: localhost
      ibm_svc_vol_map:
        clustername: "{{svc_ip}}"
        username: "{{ svcuser }}"
        password: "{{ svcpassword }}"
        log_path: "/tmp/playbook.debug"
        volname: "{{ volume_name }}"
        host: "{{ host_name }}"
        state: present
        scsi: "0" # XXX
autocoder10 commented 4 years ago

I am also looking for those extra parameters when creating volumes using "ibm_svc_vdisk" and also if you can include these additional "sync_rate" and "warning" that would be great.

  ibm_svc_vdisk:
    clustername: '{{ svc_ip }}'
    username: "{{ svcuser }}"
    password: "{{ svcpassword }}"
    log_path: /tmp/playbook.debug
    name: "{{ volume_name }}"
    state: present
    mdiskgrp: '{{ svc_pool }}'
    easytier: 'on'
    autoexpand: 'on'
    size: "200"
    unit: gb
    iogrp: io_grp0  # XXX
    **sync_rate: 80** 
    **warning: 0**

Example CLI command:

mkvdisk -mdiskgrp -iogrp -unit gb -size -rsize -autoexpand -syncrate 80 -warning 0 -name

autocoder10 commented 4 years ago

Please ignore my previous comment. I have updated the existing module to add all the required parameters. Thanks.

robinsg commented 3 years ago

SUMMARY

Can you please support some extra parameters such as io group for volumes, and scsi lun ID for volume mapping.

Ideally the ansible module should just support the full list of options that the cli provides :) but these are definitely my top 2

ISSUE TYPE
  • Feature Idea
COMPONENT NAME
  • ibm_svc_vdisk
  • ibm_svc_vol_map
ADDITIONAL INFORMATION

Expecting module to look like this:

      ibm_svc_vdisk:
        clustername: '{{ svc_ip }}'
        username: "{{ svcuser }}"
        password: "{{ svcpassword }}"
        log_path: /tmp/playbook.debug
        name: "{{ volume_name }}"
        state: present
        mdiskgrp: '{{ svc_pool }}'
        easytier: 'on'
        autoexpand: 'on'
        size: "200"
        unit: gb
        iogrp: io_grp0  # XXX

    - name: Map volume to host
      delegate_to: localhost
      ibm_svc_vol_map:
        clustername: "{{svc_ip}}"
        username: "{{ svcuser }}"
        password: "{{ svcpassword }}"
        log_path: "/tmp/playbook.debug"
        volname: "{{ volume_name }}"
        host: "{{ host_name }}"
        state: present
        scsi: "0" # XXX

I'll second that request, especially for IO group.

Shilpi-J commented 3 years ago

"iogrp" is available in new module ibm_svc_manage_volume for standard volumes "scsi" parameter is also available in ibm_svc_vol_map module