search

ansible-collections / junipernetworks.junos

Ansible Network Collection for Juniper JunOS
GNU General Public License v3.0
82 stars 64 forks source link

no_copy: no for junos_package misleading #168

Open i4o opened 3 years ago

i4o commented 3 years ago

Seriously guys? Who came with idea of no_copy: no . I can wrap my head around trying to figure out what to put there, if my image is already copied to device. Those images are huge, I doubt anybody wants to copy image during change window in production. src parameter is also not helping there. Is it going to work if I put there /var/tmp/jinstallxxxx. What is localized path or full path? Is it local to ansible machine or local to destination juniper router?

Examples are shorten for brewity . You have there 3 examples, practically useless.

i4o commented 3 years ago

Additional issues with documentation of junos_package:

provider is marked as depreciated, nowhere is mentioned that for module junos_package ( and probably also junos_scp ) it's practically compulsory. I have seen everywhere in Enterprise only aaa server config. That means username, password authentication via tacacs server. In our case we are using Ansible Tower to automate work, where local config is nonexistent.

It would be nice to mention that junos_package requires special treatment, compared to other junos_xxx packages. That it ignores ansible_host and user is forced to use ansible connection type local, instead of netconf. Otherwise you'll get : 

  ValueError: You must provide either 'host' or 'sock_fd' value )

It took me some time to google and realize, that this issue is still an issue, just nobody cares, because there is a workaround. Why would anybody mention this in module documentation, right?

i4o commented 3 years ago

Additional documentation issue, this time module junos_config

comment ... if I provide comment, it's ignored. According to documentation If the confirm argument is set to False, this argument is silently ignored.

But confirm is not boolean, it's integer??? And by default 0.