ansible-collections / kubernetes.core

The collection includes a variety of Ansible content to help automate the management of applications in Kubernetes and OpenShift clusters, as well as the provisioning and maintenance of clusters themselves.
Other
214 stars 133 forks source link

[PR #676/19559892 backport][stable-3] fix(Collection's util resource discovery fails when complex subresources present #659) #687

Closed patchback[bot] closed 7 months ago

patchback[bot] commented 7 months ago

This is a backport of PR #676 as merged into main (1955989278e3c3084c8a6fdebedf129a89041237).

SUMMARY

Hi, We have the same problem and on our side we have fixed the code, specifying to the split to do it only on the first /.

resource, name = subresource["name"].split("/", 1)

It seems more logical to add this control, since the current code doesn't support more than two elements

ISSUE TYPE
COMPONENT NAME

discovery.py

softwarefactory-project-zuul[bot] commented 7 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/4d762e66f8524038ab241456209604ab

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 48s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 27s

softwarefactory-project-zuul[bot] commented 7 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5f193b139f884402ad3b5099d67a2d07

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 47s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 14s

softwarefactory-project-zuul[bot] commented 7 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/caf33f1bd36340b988ebacef997ae1a8

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 58s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 26s