ansible-collections / kubernetes.core

The collection includes a variety of Ansible content to help automate the management of applications in Kubernetes and OpenShift clusters, as well as the provisioning and maintenance of clusters themselves.
Other
216 stars 137 forks source link

k8s: Display warnings to users #701

Closed 0xFelix closed 6 months ago

0xFelix commented 7 months ago
SUMMARY

This changes K8sService and the k8s module so warnings returned by the K8S API are displayed to the user.

Fixes https://github.com/kubevirt/kubevirt.core/issues/30 Fixes https://github.com/kubevirt/kubevirt.core/issues/31

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION

Before:

TASK [Create VM] **********************************************************************************************************************************************
ok: [localhost]

After:

TASK [Create VM] **********************************************************************************************************************************************
[WARNING]: unknown field "spec.template.spec.disk"
[WARNING]: unknown field "spec.template.spec.domain.bogus"
ok: [localhost]
softwarefactory-project-zuul[bot] commented 7 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/159898d155b8430c91c8216bdcaeb3b9

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 36s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 51s

0xFelix commented 6 months ago

Updated to address CI failures.

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fb875328ccae4d60b97106e2b6c1ac32

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 28s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 53s

0xFelix commented 6 months ago

Remaining CI failures do not look to be related to changes in this PR?

gravesm commented 6 months ago

@0xFelix yes, you can ignore the sanity failures on milestone and devel branches. Will try to get to a review soon.

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5f3ce2a920634a608150638d7f61ec98

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 04s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 32s

0xFelix commented 6 months ago

Update again to fix CI failures. k8s_apply did not respect the serialize parameter when using server side apply or getting existing resources.

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/8a89a256f45343f2a5adc8c194c3bf05

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 02s :heavy_check_mark: build-ansible-collection SUCCESS in 8m 09s

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/ed2ccad7624645f1a91975b51e63cb15

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 10m 26s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 53s