search

ansible-collections / kubernetes.core

The collection includes a variety of Ansible content to help automate the management of applications in Kubernetes and OpenShift clusters, as well as the provisioning and maintenance of clusters themselves.
Other
204 stars 130 forks source link

Fix unsafe text assertion in tests #716

Closed gravesm closed 1 month ago

gravesm commented 1 month ago
SUMMARY

This fixes a problem with unsafe text in an assertion.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3ba4020f7b7c441c83d534a2d64e780f

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 8m 46s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 27s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/b678f15b368d4f1480cb40f114d1677a

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 44s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 01s

patchback[bot] commented 1 month ago

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8858b191213765e53049e254db35ef2d0ca754cc on top of patchback/backports/stable-3/8858b191213765e53049e254db35ef2d0ca754cc/pr-716

Backporting merged PR #716 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/kubernetes.core.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-3/8858b191213765e53049e254db35ef2d0ca754cc/pr-716 upstream/stable-3
  4. Now, cherry-pick PR #716 contents into that branch: 
    $ git cherry-pick -x 8858b191213765e53049e254db35ef2d0ca754cc

    If it'll yell at you with something like fatal: Commit 8858b191213765e53049e254db35ef2d0ca754cc is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x 8858b191213765e53049e254db35ef2d0ca754cc
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #716 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-3/8858b191213765e53049e254db35ef2d0ca754cc/pr-716
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.