ansible-collections / mellanox.onyx

onyx
GNU General Public License v3.0
10 stars 14 forks source link

Add ignore.txt for 2.12, fix security issues #13

Closed Andersson007 closed 3 years ago

Andersson007 commented 3 years ago
SUMMARY

https://github.com/ansible-collections/overview/issues/45#issuecomment-813821100

codecov[bot] commented 3 years ago

Codecov Report

Merging #13 (cd6532f) into master (45c3f9a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          79       79           
  Lines        7404     7404           
  Branches     1041     1041           
=======================================
  Hits         6339     6339           
  Misses        706      706           
  Partials      359      359           
Impacted Files Coverage Δ
plugins/modules/onyx_ntp.py 65.38% <ø> (ø)
plugins/modules/onyx_snmp_users.py 66.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba0cf7c...cd6532f. Read the comment docs.

Andersson007 commented 3 years ago

Unrelated

ERROR: plugins/modules/onyx_ntp.py:0:0: no-log-needed: Argument 'auth_key_password' in argument_spec could be a secret, though doesn't have `no_log` set found in ntp_authentication_keys
Running sanity test 'yamllint' with Python 3.6
ERROR: plugins/modules/onyx_ntp.py:0:0: no-log-needed: Argument 'ntp_authentication_keys' in argument_spec could be a secret, though doesn't have `no_log` set
ERROR: plugins/modules/onyx_ntp.py:0:0: no-log-needed: Argument 'trusted_keys' in argument_spec could be a secret, though doesn't have `no_log` set
ERROR: plugins/modules/onyx_snmp_users.py:0:0: no-log-needed: Argument 'auth_password' in argument_spec could be a secret, though doesn't have `no_log` set found in users

see https://github.com/ansible-collections/overview/issues/45#issuecomment-798891436