ansible-collections / mellanox.onyx

onyx
GNU General Public License v3.0
10 stars 14 forks source link

Migrate: Mellanox Onyx Ansible Collection #2

Closed samerd closed 4 years ago

samerd commented 4 years ago

Signed-off-by: Samer Deeb samerd@mellanox.com

SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
samerd commented 4 years ago

This PR merges all onyx modules from ansible to ansible-collection. Yet, I need to set CI mechanism

gundalow commented 4 years ago

For CI copy lines 1-24 from https://github.com/ansible-collections/community.grafana/blob/master/.github/workflows/ansible-test.yml

Change line 13 to be mellanox/onyx

Is this content being moved out of another collection? If so this maybe of use https://github.com/ansible-collections/overview/blob/master/README.rst#q-what-should-i-do-to-move-plugins-across-collections-during-migration

samerd commented 4 years ago

Thanks so much @gundalow , this collection is migrated from: community.network, so I'll create a PR for onyx removal from community.network

gundalow commented 4 years ago

Thanks, and a 3rd PR to update ansible/ansible's runtime.yml (which will need backporting to the stable-2.10 branch)

thedoubl3j commented 4 years ago

great to see @samerd! if you need any help with the other PRs, please feel free to tag me and I will review and give a :heavy_check_mark: where appropriate.

edit: also, feel free to merge these when you are comfortable (I know you are waiting for CI), our review is not needed as this is your repo though I do appreciate the tag for visibility!

gundalow commented 4 years ago

Not sure why CI hasn't been triggered. Going to close/open the PR.

samerd commented 4 years ago

@gundalow : I've completed all 3 PRs for migration, please review. Thanks.

gundalow commented 4 years ago

@samerd Excellent, thank you. I'm not sure why GitHub actions hasn't been run here.

Though this is your repo, so you are free to hit merge

samerd commented 4 years ago

Thanks, I'll merge