Closed samerd closed 4 years ago
This PR merges all onyx modules from ansible to ansible-collection. Yet, I need to set CI mechanism
For CI copy lines 1-24 from https://github.com/ansible-collections/community.grafana/blob/master/.github/workflows/ansible-test.yml
Change line 13 to be mellanox/onyx
Is this content being moved out of another collection? If so this maybe of use https://github.com/ansible-collections/overview/blob/master/README.rst#q-what-should-i-do-to-move-plugins-across-collections-during-migration
Thanks so much @gundalow , this collection is migrated from: community.network, so I'll create a PR for onyx removal from community.network
Thanks, and a 3rd PR to update ansible/ansible's runtime.yml (which will need backporting to the stable-2.10 branch)
great to see @samerd! if you need any help with the other PRs, please feel free to tag me and I will review and give a :heavy_check_mark: where appropriate.
edit: also, feel free to merge these when you are comfortable (I know you are waiting for CI), our review is not needed as this is your repo though I do appreciate the tag for visibility!
Not sure why CI hasn't been triggered. Going to close/open the PR.
@gundalow : I've completed all 3 PRs for migration, please review. Thanks.
@samerd Excellent, thank you. I'm not sure why GitHub actions hasn't been run here.
Though this is your repo, so you are free to hit merge
Thanks, I'll merge
Signed-off-by: Samer Deeb samerd@mellanox.com
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION