ansible-collections / mellanox.onyx

onyx

GNU General Public License v3.0

10 stars 14 forks source link

Fix CI unit tests #4

Closed samerd closed 4 years ago

samerd commented 4 years ago

Signed-off-by: Samer Deeb samerd@mellanox.com

SUMMARY

Fix unit tests: add missing functions

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

gundalow commented 4 years ago

@samerd FYI I've pushed a commit which should fix ansible.netcommon so you will need to git pull locally

gundalow commented 4 years ago

Remove these lines

ERROR: tests/sanity/ignore-2.11.txt:8:1: A100: Ignoring 'nonexistent-parameter-documented' on 'plugins/modules/onyx_command.py' is unnecessary
ERROR: tests/sanity/ignore-2.11.txt:12:1: A100: Ignoring 'nonexistent-parameter-documented' on 'plugins/modules/onyx_config.py' is unnecessary

ERROR: Found 6 ignores issue(s) which need to be resolved:
ERROR: tests/sanity/ignore-2.11.txt:70:1: File 'plugins/modules/onyx_ntp.py' does not exist
ERROR: tests/sanity/ignore-2.11.txt:71:1: File 'plugins/modules/onyx_ntp_servers_peers.py' does not exist
ERROR: tests/sanity/ignore-2.11.txt:90:1: File 'plugins/modules/onyx_snmp.py' does not exist
ERROR: tests/sanity/ignore-2.11.txt:91:1: File 'plugins/modules/onyx_snmp_hosts.py' does not exist

ERROR: tests/sanity/ignore-2.11.txt:92:1: File 'plugins/modules/onyx_snmp_users.py' does not exist
ERROR: tests/sanity/ignore-2.11.txt:93:1: File 'plugins/modules/onyx_syslog_remote.py' does not exist

samerd commented 4 years ago

thanks so much for the review and the help @gundalow much appreciated

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9da16b2). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   85.61%           
=========================================
  Files             ?       79           
  Lines             ?     7404           
  Branches          ?     1041           
=========================================
  Hits              ?     6339           
  Misses            ?      706           
  Partials          ?      359

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9da16b2...04f0c5d. Read the comment docs.

gundalow commented 4 years ago

@samerd Great work!