ansible-collections / netapp.ontap

Ansible collection to support NetApp ONTAP configuration.
https://galaxy.ansible.com/netapp/ontap
GNU General Public License v3.0
55 stars 35 forks source link

Timeout set too high for snapmirror_rest_create in collection 22.4.0 #142

Closed 0xlnz closed 1 year ago

0xlnz commented 1 year ago

Summary

I'm trying to create a snapmirror relationship using REST, getting error

    "msg": "Error creating SnapMirror: calling: snapmirror/relationships: got {'message': 'The value \"600\" is invalid for field \"return_timeout\" (<0..120>)', 'code': '262197', 'target': 'return_timeout'}."

I'm assuming the timeout set here is too high? https://github.com/ansible-collections/netapp.ontap/blob/414706edd847a3aeb3255f3077d65737a6405c50/plugins/modules/na_ontap_snapmirror.py#L1467

it should be between 0 and 120

Component Name

netapp.ontap.na_ontap_snapmirror

Ansible Version

$ ansible --version
ansible [core 2.14.3]
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.9/dist-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110] (/usr/bin/python3)
  jinja version = 3.1.2
  libyaml = True

ONTAP Collection Version

$ ansible-galaxy collection list

Collection     Version
-------------- -------
netapp.ontap   22.4.0

ONTAP Version

NetApp Release 9.11.1

Playbook

tasks:
    - name: Create vserver SnapMirror DR - PRESERVE IDENTITY
      na_ontap_snapmirror:
        state: present
        create_destination:
          enabled: true
        source_endpoint: 
          cluster: "{{ Cluster_A_IP }}"
          path: "{{ source_vserver }}:"
        destination_endpoint: 
          cluster: "{{ Cluster_B_IP }}"
          path: "{{ dest_vserver }}:"
        identity_preservation: full
        policy: "{{ snapMirrorPolicy }}"
        schedule: "hourly"
        <<: *login

Steps to Reproduce

Creating a snapmirror svmdr relationship using REST with the above task

Expected Results

vserver created on destination and snapmirror svmdr relationship initialized

Actual Results

"msg": "Error creating SnapMirror: calling: snapmirror/relationships: got {'message': 'The value \"600\" is invalid for field \"return_timeout\" (<0..120>)', 'code': '262197', 'target': 'return_timeout'}."
0xlnz commented 1 year ago

Task works as expected if i manually set the timeout back to 60 in /plugins/modules/na_ontap_snapmirror.py#L1467

0xlnz commented 1 year ago

fixed in 22.4.1! Thanks :)