search

ansible-collections / netapp.ontap

Ansible collection to support NetApp ONTAP configuration.
https://galaxy.ansible.com/netapp/ontap
GNU General Public License v3.0
51 stars 34 forks source link

Add certificate management to na_ontap_ems_destination #174

Closed seb0s closed 8 months ago

seb0s commented 10 months ago
SUMMARY

Add certificate management capability to na_ontap_ems_destination module.

ISSUE TYPE
seb0s commented 10 months ago

I added all your suggestion, thanks for your review.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6f613b4) 91.74% compared to head (37b6a56) 91.68%. Report is 6 commits behind head on main.

:exclamation: Current head 37b6a56 differs from pull request most recent head 80e074a. Consider uploading reports for the commit 80e074a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #174 +/- ## ========================================== - Coverage 91.74% 91.68% -0.06% ========================================== Files 347 347 Lines 55114 55307 +193 Branches 7292 7339 +47 ========================================== + Hits 50563 50708 +145 - Misses 2569 2594 +25 - Partials 1982 2005 +23 ``` | [Files](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [...t/plugins/modules/test\_na\_ontap\_ems\_destination.py](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#diff-dGVzdHMvdW5pdC9wbHVnaW5zL21vZHVsZXMvdGVzdF9uYV9vbnRhcF9lbXNfZGVzdGluYXRpb24ucHk=) | `98.37% <100.00%> (+0.45%)` | :arrow_up: | | [plugins/modules/na\_ontap\_ems\_destination.py](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#diff-cGx1Z2lucy9tb2R1bGVzL25hX29udGFwX2Vtc19kZXN0aW5hdGlvbi5weQ==) | `97.19% <96.15%> (-0.48%)` | :arrow_down: | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carchi8py commented 8 months ago

@seb0s could you fix the sanity test. (they should report the same error but use 2.14 one.

carchi8py commented 8 months ago

@seb0s ok thank this looks good. Don't worry about the Devel failure (there something wrong with that).

I"ll see if we can get this merged this week and get this part of the next release.