ansible-collections / netapp.ontap

Ansible collection to support NetApp ONTAP configuration.
https://galaxy.ansible.com/netapp/ontap
GNU General Public License v3.0
51 stars 34 forks source link

Changes to enable the large_size_enabled option #182

Open FMFREAK040 opened 8 months ago

FMFREAK040 commented 8 months ago
SUMMARY

Enabled the large_size_enabled option to enable the creation of large files (>16TB)

Fixes #181

ISSUE TYPE
COMPONENT NAME

na_ontap_volume.py

ADDITIONAL INFORMATION

To create a volume with the -is-large-size-enabled option set. There wasn't a way to to this with Ansbile. With the adds I commit you can use this option to set the -is-large-size-enabled option with Ansible. This is necessary to let NetApp create LUN's of more than 16 TB and snapmirror them to another cluster. When this option isn't set an you created an Snapshot of more that 16TB eg. at the initialization of the Snapmirror this will fail.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (793e2ae) 91.64% compared to head (a27563a) 91.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ========================================== - Coverage 91.64% 91.64% -0.01% ========================================== Files 350 350 Lines 55651 55653 +2 Branches 7393 7394 +1 ========================================== Hits 51003 51003 - Misses 2622 2623 +1 - Partials 2026 2027 +1 ``` | [Files](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [plugins/modules/na\_ontap\_volume.py](https://app.codecov.io/gh/ansible-collections/netapp.ontap/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#diff-cGx1Z2lucy9tb2R1bGVzL25hX29udGFwX3ZvbHVtZS5weQ==) | `95.78% <0.00%> (-0.16%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FMFREAK040 commented 7 months ago

It looks like this tests will fail not on the commited code but on the ansible part, e.g. ERROR: Package 'ansible-core' requires a different Python: 3.9.18 not in '>=3.10'