search

ansible-collections / vmware.vmware

Ansible VMWare Collection
GNU General Public License v3.0
7 stars 10 forks source link

Deprecating the old module vm_list_group_by_clusters #25

Closed bardielle closed 5 months ago

bardielle commented 5 months ago
SUMMARY

Deprecating the module vm_list_group_by_clusters since it will be replaced with vm_list_group_by_clusters_info in v2.0.0

ISSUE TYPE

Adding a deprecating

COMPONENT NAME

Deprecating the module vm_list_group_by_clusters since it will be replaced with vm_list_group_by_clusters_info in v2.0.0 and since then we will have 2 modules. I used that doc in order to sign that module as deprecated

mariolenz commented 5 months ago

Just wanted to work on this, also :laughing:

bardielle commented 5 months ago

@mariolenz thank you for your comments :)

bardielle commented 5 months ago

@mariolenz @felixfontein @Andersson007 Any disclaimers regarding that PR?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.58%. Comparing base (261e57a) to head (11dee29). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## =========================================== + Coverage 13.71% 29.58% +15.86% =========================================== Files 7 8 +1 Lines 1917 605 -1312 Branches 478 112 -366 =========================================== - Hits 263 179 -84 + Misses 1654 426 -1228 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/25/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/ansible-collections/vmware.vmware/pull/25/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `29.58% <ø> (+15.86%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bardielle commented 5 months ago

thank you @felixfontein